Wireshark mailing list archives
Re: enum preferences vs Go Fish
From: mmann78 () netscape net
Date: Sat, 4 Apr 2015 07:31:06 -0400
Right now there is no way to include a "Decode As" protocol list as a specific preference of a dissector. I thought I may get some resistance here because I broke "backwards compatibility", but I thought the trade off of more easily adding dissectors to a Decode As list and having an "overall" more consistent GUI was a better decision. Specific users of a dissector may be used to going to preferences of a dissector for "Decode As" functionality, but there is no consistency. I have to go to "Preferences" for P_Mul, but not TCP or UDP. Why? Because someone added the GUI code in Decode As for TCP and UDP (when such code existed) but never got around to doing P_Mul (or some of the other more niche dissectors). I'd like to be able to "train" users (and developers) to think of Decode As before a dissector preference. I also thought I had a better chance of doing such "GUI things" with the 2.0 release where it can be more understandable. -----Original Message----- From: Stig Bjørlykke <stig () bjorlykke org> To: Developer support list for Wireshark <wireshark-dev () wireshark org> Sent: Sat, Apr 4, 2015 4:55 am Subject: Re: [Wireshark-dev] enum preferences vs Go Fish On Sat, Apr 4, 2015 at 3:30 AM, <mmann78 () netscape net> wrote:
I may have gone
a little overboard, but I tried to remove all enumerated
preferences that
really should be Decode As. There were enough nuances to
each situation, that
I made them all separate patches.
https://code.wireshark.org/review/7901
(P_MUL) For P_Mul I want the decode-as option to be available from the P_Mul preferences, and from (currently only in gtk) second-click in the packet details pane and selecting "Protocol Preferences" -> "Decode Data PDU as". This because I don't think the users will think about the global "Decode As" when trying to configure P_Mul (or any other protocol). Is this possible with the decode-as changes? Or do we have to implement something more? -- Stig Bjørlykke ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: enum preferences vs Go Fish mmann78 (Apr 03)
- Re: enum preferences vs Go Fish Stig Bjørlykke (Apr 04)
- Re: enum preferences vs Go Fish mmann78 (Apr 04)
- Re: enum preferences vs Go Fish Stig Bjørlykke (Apr 04)
- Re: enum preferences vs Go Fish Guy Harris (Apr 04)
- Re: enum preferences vs Go Fish mmann78 (Apr 06)
- Re: enum preferences vs Go Fish Stig Bjørlykke (Apr 06)
- Re: enum preferences vs Go Fish mmann78 (Apr 04)
- Re: enum preferences vs Go Fish Stig Bjørlykke (Apr 04)