Re: Support dissecting REAL (BER) data values

["Kukosa, Tomas" <tomas.kukosa () unify com>]

Hello Maarten,

the reason why REAL value decoding is in the asn1.c is that the same encoding is used for both BER and PER.
It is defined in the BER (X.690) and the PER (X.691) refers to it.

Regards,
  Tomas

________________________________________
From: wireshark-dev-bounces () wireshark org [wireshark-dev-bounces () wireshark org] on behalf of Maarten Bezemer 
[maarten.bezemer () gmail com]
Sent: Friday, November 28, 2014 5:05 PM
To: Developer support list for Wireshark
Subject: [Wireshark-dev] Support dissecting REAL (BER) data values

Hello,

I provided a patch to add (initial) support to dissect REAL (BER) data values:
https://code.wireshark.org/review/5527

For me, it all seems to be working (for my application), but I suppose that I
did not test all possible situations. So I would appreciate it, if people are
willing and able to try out the patch.

I do also have a question about the (desired) implementation.
I noticed very rudimentar/incompletey support to dissect REAL data values in
the asn1_get_real() function (epan/asn1.c). So I extended this function to add
full/better support. But, this is the only data type that is 'dissected' in
epan/asn1.c, all other types are dissected in epan/dissectors/packet-ber.c

So, I was wondering whether to move the REAL data type support from asn1.c to
packet-ber.c?

Note that packet-per.c also uses the asn1_get_real() function, I did not
test/try this encoding type, as I do not have means to do so.

Regards,
  Maarten
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe