Wireshark mailing list archives
Re: Cashe column operations to "end of packet" and only execute the visible ones to save CPU
From: Evan Huus <eapache () gmail com>
Date: Tue, 11 Mar 2014 08:05:30 -0400
That sounds like it might be a good idea. Do you have captures where the col_ API is taking a substantial amount of time? I expect the most expensive part of the col_ API is probably the formatting calls, but I'm not sure how we'd cache those. I expect we'd have to do the formatting immediately and then cache the resulting string, so I'm not sure how much benefit that would provide over just formatting in place. Worth exploring though. Evan On Tue, Mar 11, 2014 at 5:20 AM, Anders Broman <anders.broman () ericsson com> wrote:
Hi, How about this idea? Would it be possible to stack the col..() operations and just execute the relevant ones to save on CPU? Currently we overwrite the data as we work our way through the packet Until we hit a col_set_fence() then we start to overwrite the stuff after the fence again. One problem might be exceptions - other? Best regards Anders ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Cashe column operations to "end of packet" and only execute the visible ones to save CPU Anders Broman (Mar 11)
- Re: Cashe column operations to "end of packet" and only execute the visible ones to save CPU Evan Huus (Mar 11)
- Re: Cashe column operations to "end of packet" and only execute the visible ones to save CPU Anders Broman (Mar 11)
- Re: Cashe column operations to "end of packet" and only execute the visible ones to save CPU Evan Huus (Mar 11)