Wireshark mailing list archives

Re: [PATCH] reduce scope of and close a file descriptor in wsutil/sha1.c

From: Guy Harris <guy () alum mit edu>
Date: Mon, 9 Jun 2014 13:57:34 -0700


On Jun 9, 2014, at 1:43 PM, Jakub Zawadzki <darkjames-ws () darkjames pl> wrote:

On Mon, Jun 09, 2014 at 07:32:49PM +0200, Toralf Förster wrote:

+        ws_close(f);


          ^^^ fclose(f) ?


Yes.

ws_close() seems to be taking file descriptor.


Yes, it's just a #define for close on UN*X and for _close on Windows.  A FILE * is, obviously, closed by fclose() on 
all OSes, so no need for ws_fclose().

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread:

[PATCH] reduce scope of and close a file descriptor in wsutil/sha1.c Toralf Förster (Jun 09)
- Re: [PATCH] reduce scope of and close a file descriptor in wsutil/sha1.c Jakub Zawadzki (Jun 09)
  - Re: [PATCH] reduce scope of and close a file descriptor in wsutil/sha1.c Guy Harris (Jun 09)