Re: MAKEDIR NSIS packaging issue with Wireshark 1.10.8

[Graham Bloice <graham.bloice () trihedral com>]

On 24 June 2014 14:07, Ben Burwell <bburwell () lutron com> wrote:

> Hello,
>
> When trying to create a package using NSIS, I've run into an issue where
> $MAKEDIR contains spaces (C:\Program Files (x86)\...), which does not seem
> to be handled correctly.
>
> I've found this bug report, which is nearly two years old:
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7870
>
> For example (from the bug report):
>
> #nmake -f Makefile.nmake
> ......
> "C:\Program Files\NSIS\makensis.exe"  /DPROGRAM_NAME=wireshark
> /DMAKEDIR=C:\Documents and
> Settings\Administrator\test\wireshark\packaging\nsis
> ......
> Command line defined: "PROGRAM_NAME=wireshark"
> Command line defined: "MAKEDIR=C:\Documents"
> ......
> Can't open script "and"
> NMAKE : fatal error U1077: '"C:\Program Files\NSIS\makensis.exe"' : return
> code'0x1'Stop.
> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio
> 10.0\VC\BIN\nmake.exe"' : return code '0x2' Stop.
> ......
>
> From what I can see, this is still open and present in releases, though a
> patch has been submitted in the bug report.
>
> I was unable to find anything related in Gerrit. Does the patch attached
> in the bug report just need to be submitted on Gerrit?

Submitting the patch equivalent to Gerrit is the way forward.  Remember to
add the bug number in the footer of the commit message "Bug: 7870".

It would appear that almost everyone else using Windows is compiling
Wireshark in a directory without spaces, but I don't see a problem in
adding the proposed change.

-- 
Graham Bloice

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe