Wireshark mailing list archives

Re: [Wireshark-commits] master 9079e3a: Cheat and try to fix the generated file manually.


From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Mon, 23 Jun 2014 22:22:10 +0200

Hello Evan,

On Mon, Jun 23, 2014 at 02:10:13PM -0400, Evan Huus wrote:
Storing generated files in source control makes maintenance and patch
review much harder and puts extra requirements on us to keep things in
sync. I'd rather the computer do the extra work :)

But in the same time, we can have 3rd party library, like nghttp2[1] (12KLOC) put into git.

This is already more than 30 commits behind nghttp2/lib git HEAD,
nor README.nghttp2 is updated about recent fixes in this forked code.

We store C files and require a compiler, where we could just store the
compiled .o files in source control. To me this is much the same thing.

Great to know.

Balint and Jörg and I discussed that we would eventually like to remove the
ASN.1 generated source from git as well, and make that a standard part of
the build process.

I am happy to hear this, please do.
For sure you want also do this for X11 dissector, which for rebuilt only requires
downloading mesa sources.


BR,
Jakub.

[1] I am very sorry Alexis, but I haven't found better example.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: