Re: [Wireshark-commits] rev 53090: /trunk/ /trunk/asn1/acse/: acse.cnf packet-acse-template.c /trunk/asn1/cmip/: cmip.cnf packet-cmip-template.c /trunk/asn1/disp/: packet-disp-template.c /trunk/epan/dissectors/: ...

[Stig Bjørlykke <stig () bjorlykke org>]

On Fri, Jan 10, 2014 at 12:56 PM, Stig Bjørlykke <stig () bjorlykke org> wrote:
> This commit introduced a bug where I always get
> "[Malformed Packet: PRES]" in X.400 traffic.

Reassembly in RTSE is a bit special. The reassembly is done when
receiving a SES "MAJOR SYNC POINT", as this indicates the end of the
COTP DT Data stream.  The payload for this pdu is empty, which results
in a empty tvb being sent to RTSE (which then reassemble all previous
received payloads).

Updating the RTSE dissector to a new-style was done by returning
tvb_length(tvb), which in this case is always 0.  Returning 0 from a
new-style dissector means this package was not for us, which is wrong
in this case.

I've added a fix for this in 54693.


-- 
Stig Bjørlykke
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe