Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On 12/14/2014 03:03 PM, Bill Meier wrote:
> On 12/14/2014 2:22 PM, Stephen Fisher wrote:
> > On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote:
> >
> > > That being said, the convention (certainly not enforced) seems to be
> > > to use ENC_..._ENDIAN for fetching all integral types.
> >
> > Could this be related to when we made the change from using FALSE / TRUE
> > to specify if its "big endian" in things like proto_tree_add_item() ?
>
>
> Good point !
>
> fix-encoding-args.pl (used to do the change) just converted FALSE|0 to
> BIG_ENDIAN and etc, so the "convention" actually kind-of-happened
> because previously TRUE|1 or FALSE|0 were the only choices for the
> 'encoding-arg".
>
> So, I stand corrected.
>
> Maybe what I should be doing is converting all the single-byte fetches
> to use ENC_NA.
>
> Thoughts ?

We discussed this some time ago; the consensus at the time seemed to be 
use ENC_*_ENDIAN for 1-byte fields:

https://www.wireshark.org/lists/wireshark-dev/201107/msg00404.html

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe