Re: QT_MIN_VERSION

[Alexis La Goutte <alexis.lagoutte () gmail com>]

On Fri, Aug 8, 2014 at 6:14 PM, Maynard, Chris
<Christopher.Maynard () gtech com> wrote:
> > -----Original Message-----
> > From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-
> > bounces () wireshark org] On Behalf Of Michal Labedzki
> > Sent: Friday, August 08, 2014 1:46 AM
> > To: Developer support list for Wireshark
> > Subject: Re: [Wireshark-dev] QT_MIN_VERSION
> >
> > I use "" instead of "styleName()" and everything seems to be ok. What
> > about use
> > conditional define with QT version?
> >
> > However I vote for update to 4.8.0
>
> I would prefer not to do this, if at all possible, until at least the end of
> the RHEL6 Production 1 Phase.
> https://access.redhat.com/support/policy/updates/errata
Ok no a problem for me
Can you try this patch ?
https://code.wireshark.org/review/3508


> Currently we don't necessarily have any particular need or desire to deploy
> qtshark on these systems; however:
> 1) Others may want to?
> 2) I'm unable to create .rpm's using --without-qt. (or with both
> --without-gtk2 and --without-gtk3 for that matter, but that hasn’t been a
> problem since I just don’t bother installing the gnome rpm that’s
> generated.)
>
> RHEL6 doesn't have GTK3, so I’m forced to use, at a minimum, --with-gtk2,
> and of course change wireshark.spec.in as well:
>
> %bcond_with    gtk2
> %bcond_without gtk3
> %bcond_without qt
>
> Unfortunately, that fails as follows:
>
> …
>
> + desktop-file-validate
> /home/wireshark/wireshark-1.12.0/packaging/rpm/BUILDROOT/wireshark-1.12.0-1.x86_64/usr/share/applications/wireshark.desktop
> + /usr/lib/rpm/brp-compress
> + /usr/lib/rpm/brp-strip
> + /usr/lib/rpm/brp-strip-static-archive
> + /usr/lib/rpm/brp-strip-comment-note
> Processing files: wireshark-1.12.0-1.x86_64
> error: File not found:
> /home/wireshark/wireshark-1.12.0/packaging/rpm/BUILDROOT/wireshark-1.12.0-1.x86_64/usr/local/bin/wireshark-qt
> Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.IxX5Gn
>
> …
>
> RPM build errors:
>     File not found:
> /home/wireshark/wireshark-1.12.0/packaging/rpm/BUILDROOT/wireshark-1.12.0-1.x86_64/usr/local/bin/wireshark-qt
> make: *** [rpm-package] Error 1
>
> Incidentally, the same type of failure happens if you try using
> --without-gtk2 --without-gtk3 --with-qt=yes instead, along with:
>
> %bcond_without gtk2
> %bcond_without gtk3
> %bcond_with   qt
>
> as well as the change to ui/qt/qt_ui_utils.cpp to use “” instead of
> font.styleName():
>
> …
>
> + desktop-file-validate
> /home/wireshark/wireshark-1.12.0/packaging/rpm/BUILDROOT/wireshark-1.12.0-1.x86_64/usr/share/applications/wireshark.desktop
> + /usr/lib/rpm/brp-compress
> + /usr/lib/rpm/brp-strip
> + /usr/lib/rpm/brp-strip-static-archive
> + /usr/lib/rpm/brp-strip-comment-note
> Processing files: wireshark-1.12.0-1.x86_64
> error: File not found:
> /home/wireshark/wireshark-1.12.0/packaging/rpm/BUILDROOT/wireshark-1.12.0-1.x86_64/usr/local/bin/wireshark-gtk
> Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.v8wtRC
>
> …
>
> RPM build errors:
>     File not found:
> /home/wireshark/wireshark-1.12.0/packaging/rpm/BUILDROOT/wireshark-1.12.0-1.x86_64/usr/local/bin/wireshark-gtk
> make: *** [rpm-package] Error 1

Need to see with Jeff..
> > On 7 August 2014 20:13, Christopher Maynard
> > <Christopher.Maynard () gtech com>
> > wrote:
> > > configure.ac lists QT_MIN_VERSION as 4.6.0.
> > >
> > > Attempting to compile 1.12.0 on RHEL6 with qt-4.6.2-24.el6.x86_64 fails
> > > with:
> > >
> > > qt_ui_utils.cpp: In function 'void smooth_font_size(QFont&)':
> > > qt_ui_utils.cpp:58: error: 'class QFont' has no member named 'styleName'
> > >
> > > Apparently styleName isn't available until 4.8.0.
> > >
> > > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;
> > > h=8afb6106f2fb565aff0ec9f00b3dcf7217ed5255
> > >
> > > Ideas as to how best to fix these ... besides setting QT_MIN_VERSION to
> > > 4.8.0?
>
>
> CONFIDENTIALITY NOTICE: The information contained in this email message is
> intended only for use of the intended recipient. If the reader of this
> message is not the intended recipient, you are hereby notified that any
> dissemination, distribution or copying of this communication is strictly
> prohibited. If you have received this communication in error, please
> immediately delete it from your system and notify the sender by replying to
> this email.  Thank you.
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe