Wireshark mailing list archives
Re: Petri-Dish +1 gives an error: needs code review
From: mmann78 () netscape net
Date: Fri, 15 Aug 2014 15:36:35 -0400 (EDT)
I thought we intentionally wanted a (core?) developer to bless the patch (with +1) before we sent it to the Petri-Dish. No sense in testing for compile errors if someone doesn't at least like the idea of the patch. This may dilute the meaning of +1 review a little, but we also didn't necessarily want to waste the Petri-Dish's time either. -----Original Message----- From: Jeff Morriss <jeff.morriss.ws () gmail com> To: Developer support list for Wireshark <wireshark-dev () wireshark org> Sent: Fri, Aug 15, 2014 3:19 pm Subject: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying "needs code review." Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. Regards, -Jeff ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Petri-Dish +1 gives an error: needs code review Jeff Morriss (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Graham Bloice (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Evan Huus (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review mmann78 (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Gerald Combs (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Jeff Morriss (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Christopher Maynard (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Guy Harris (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Evan Huus (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Alexis La Goutte (Aug 16)
- Re: Petri-Dish +1 gives an error: needs code review Graham Bloice (Aug 16)
- Re: Petri-Dish +1 gives an error: needs code review Alexis La Goutte (Aug 16)
- Re: Petri-Dish +1 gives an error: needs code review Jeff Morriss (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Graham Bloice (Aug 15)