Re: Fwd: [Wireshark-commits] rev 52741: Add APIs for PIDL generated code to return the value of the integer that was dissected.

[mmann78 () netscape net]

These PIDL APIs do a wrapper of "add integer to tree" + "add integer to column (info) data", not just a simple "add 
integer to tree, return value"



-----Original Message-----
From: Anders Broman <a.broman () bredband net>
To: Developer support list for Wireshark <wireshark-dev () wireshark org>
Sent: Mon, Oct 21, 2013 3:54 pm
Subject: [Wireshark-dev] Fwd: [Wireshark-commits] rev 52741: Add APIs for PIDL generated code to return the value of 
the integer that was dissected.


          
    
    
Hi,
      Shouldn't something generic based on 
      proto_tree_add_bits_ret_val()
      be used instead?
      
      Regards
      Anders
      
      
      -------- Ursprungligt meddelande --------      
        
          
            
Ämne: 
            
[Wireshark-commits] rev 52741: /trunk/epan/dissectors/              /trunk/epan/dissectors/: packet-dcerpc-ndr.c        
      packet-dcerpc.h
          
          
            
Datum: 
            
Mon, 21 Oct 2013 18:25:42 GMT
          
          
            
Från: 
            
mmann () wireshark org
          
          
            
Svar              till: 
            
wireshark-dev () wireshark org
          
          
            
Till: 
            
wireshark-commits () wireshark org
          
        
      
      
      
      
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52741

User: mmann
Date: 2013/10/21 06:25 PM

Log:
 Add APIs for PIDL generated code to return the value of the integer that was dissected.  Bug 9305 
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9305).
 
 From Matthieu Patou

Directory: /trunk/epan/dissectors/
  Changes    Path                   Action
  +55 -12    packet-dcerpc-ndr.c    Modified
  +5 -1      packet-dcerpc.h        Modified

___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request () wireshark org?subject=unsubscribe


      
    
    
  

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

 

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe