Re: [Wireshark-commits] rev 52341: /trunk/epan/ /trunk/epan/dissectors/: packet-usb-video.c /trunk/epan/: expert.h proto.c proto.h

[mmann78 () netscape net]

The attached patch implements the "_ws." prefix for "wireshark (internal) protocols".  Taps were (intentionally) left 
alone. The filters themselves work, but it exposes a bug (?) with the display filter dialog - the 
intellisense/autocomplete doesn't look for "protocols" after the first period is entered.  Typing "_ws" exposes all of 
the new (protocol) filters, but when "_ws." is typed, all of the protocols aren't in the list, just the (new) expert 
filters.  Verified this with other protocols (like gluster.cli) as well.  For something as popular as the "malformed" 
display filter, the issue should probably be addressed before this patch is applied.

Since filterable expert info is the driving force for creating these "protocols" and it's only available in 1.11, there 
was no intention of backporting.  I just figured "malformed" was so commonly used, it would be somewhat of a shock to 
users when it changes.


-----Original Message-----
From: Joerg Mayer <jmayer () loplof de>
To: Developer support list for Wireshark <wireshark-dev () wireshark org>
Sent: Fri, Oct 4, 2013 11:38 am
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 52341: /trunk/epan/ /trunk/epan/dissectors/: packet-usb-video.c 
/trunk/epan/: expert.h proto.c proto.h


On Fri, Oct 04, 2013 at 10:12:08AM -0400, mmann78 () netscape net wrote:
 
 I like the suggestion of a "_ws." prefix, but my hesitation is backwards 
ompatibility.  The only "not real" protocol filter I use consistently is 
malformed" and I like that simplicity.  And the other "protocols" in 
how_exception.c seem reasonable, but like you said, it starts to get ugly for 
ome of the "lesser" error cases.  
IMO we should not change the 1.10 code, but I don't mind breaking things
n 1.11 - we are doing that all the time. Of course it needs to be part
f the 1.12/2.0 release notes.
> Should I provide a patch here with your suggestion or log something in 
ugzilla for people to test?
Both methods are fine with me, maybe a ml post will draw more responses.
Ciao
    Jörg
- 
oerg Mayer                                           <jmayer () loplof de>
e are stuck with technology when what we really want is just stuff that
orks. Some say that should read Microsoft instead of technology.
__________________________________________________________________________
ent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
rchives:    http://www.wireshark.org/lists/wireshark-dev
nsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Attachment: _ws.protocol.patch
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe