Wireshark mailing list archives
Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h
From: Evan Huus <eapache () gmail com>
Date: Sun, 13 Oct 2013 16:43:28 -0400
On Sun, Oct 13, 2013 at 3:54 AM, Jakub Zawadzki <darkjames-ws () darkjames pl> wrote:
About tvb_offset_exists() comment, compute_offset() is not returning exception when offset == tvb->length.
Ah, OK. Should it? When offset == tvb->length I would think that should be an exception, since no bytes exist at that location. There are other places that call compute_offset and don't check the == case that maybe should... Evan ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h Evan Huus (Oct 12)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h Jakub Zawadzki (Oct 13)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h Evan Huus (Oct 13)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h didier (Oct 13)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h Pascal Quantin (Oct 14)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h didier (Oct 18)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h Evan Huus (Oct 13)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h Jakub Zawadzki (Oct 13)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h Jakub Zawadzki (Oct 13)
- Re: [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h Evan Huus (Oct 17)