Re: [Wireshark-commits] rev 49596: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-l2tp.c packet-lapd.c packet-ldp.c packet-lisp-data.c packet-lmp.c packet-ltp.c packet-m2pa.c packet-mbtcp.c packet-meta.c packet-miop.c ...

[Joerg Mayer <jmayer () loplof de>]

On Tue, May 28, 2013 at 10:24:21AM -0400, mmann78 () netscape net wrote:
> expert_add_info_format_text()
>
> Per some of the other discussions, this may not be the best name, but I would like to eventually replace it with the 
> existing expert_add_info_format name, just with the expert info structure as an argument (an no severity, group 
> arguments), so that the "format"ing (printf) functionality is clearer.

Ah, thanks. I missed that part when looking at the changes to packet-arp.c
One question though: Why do we have a filled in text element (e.g. in packet-arp.c
we have "Duplicate IP address configured") in the ei[] array when the
call does require an actual formatting string (e.g. in packet-arp.c the arguemnt
to expert_add_info_format_text is "Duplicate IP address configured (%s)").

Thanks
    Jörg

-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe