Wireshark mailing list archives
Re: [Wireshark-commits] rev 48652: /trunk/ui/gtk/ /trunk/ui/gtk/: capture_dlg.c
From: Jaap Keuter <jaap.keuter () xs4all nl>
Date: Sat, 30 Mar 2013 20:36:28 +0100
On 03/30/2013 05:09 PM, Bill Meier wrote:
On 3/30/2013 7:57 AM, jake () wireshark org wrote:http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=48652 User: jake Date: 2013/03/30 04:57 AM Log: Have 'Capture file' and 'Stop after' extries left aligned in GTK+ 3 as well. Directory: /trunk/ui/gtk/ Changes Path Action +49 -23 capture_dlg.c ModifiedThe fix was to use ws_gtk_grid_attach_extended() with just GTK_FILL as the X & Y options in various places. My understanding of the normal expected semantics of GTK_FILL is that it only takes effect when GTK_EXPAND is used. So: I'll have to look at the way I implemented ws_gtk_grid_attach_extended() using halign and valign for GTK3 to see if it's OK or if I should change something (and thus if I need to change the fix in SVN #48652 and possibly change other calls to ws_gtk_grid...). Bill
He Bill, This was merely try and error, taking out flags from _default() until it worked. Then of course restoring _default() to its original glory and change the applicable _extended() calls accordingly. I wouldn't be surprised if it could be cleaned up further. Thanks, Jaap ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 48652: /trunk/ui/gtk/ /trunk/ui/gtk/: capture_dlg.c Bill Meier (Mar 30)
- Re: [Wireshark-commits] rev 48652: /trunk/ui/gtk/ /trunk/ui/gtk/: capture_dlg.c Jaap Keuter (Mar 30)