Wireshark mailing list archives

Re: [Wireshark-commits] rev 48445: /trunk/ui/gtk/ /trunk/ui/gtk/: capture_dlg.c conversations_table.c gui_utils.c gui_utils.h hostlist_table.c


From: Jaap Keuter <jaap.keuter () xs4all nl>
Date: Thu, 21 Mar 2013 07:57:53 +0100

On 03/21/2013 02:33 AM, Bill Meier wrote:
On 3/20/2013 6:41 PM, gerald () wireshark org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=48445

User: gerald
Date: 2013/03/20 03:41 PM



Gerald:

There recently was an issue in capture_if_dlg.c where the use of
gtk_window_get_size() and gtk_window_resize() seemed not to work well on some
platforms.

In the end, what seemed to work well was to use get_widget_get_preferred_size()
and then gtk_window_set_default_size().

See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8468 for all the gory
details.

The patch attached to the bug replaced the use of get_size/resize with
get_preferred_size/set_default_size.

(Note that gtk_widget_get_preferred_size is defined as gtk_widget_size_request
for GTK2 which means that the 3rd arg to gtk_widget_get_preferred_size() is
always set to NULL).

#define gtk_widget_get_preferred_size(x,y,z) \
gtk_widget_size_request(x,y)

Bill


Hi all,

As a side note, the bug is still 'in progress' because we haven't heard of an OS
X test yet. If someone could confirm, in the bug comments, that the current
Interface List dialog works properly on OS X we can close the matter.

Thanks,
Jaap


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: