Wireshark mailing list archives
New Defects reported by Coverity Scan for Wireshark (forw)
From: Joerg Mayer <jmayer () loplof de>
Date: Fri, 14 Jun 2013 14:32:02 +0200
Hi, I'm receiving coverity reports via email. Unfortunately I don't really have the time to look at them most of the time. What I might do if there is interest in it: I could open a bug for each dissector and copy the contents into the bug. Opinions? Ciao Jörg -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.
--- Begin Message --- From: scan-admin () coverity com
Date: Fri, 14 Jun 2013 04:53:58 -0700
Hi, Please find the latest report on new defect(s) introduced to Wireshark found with Coverity Scan Defect(s) Reported-by: Coverity Scan ** CID 1033205: Dead default in switch (DEADCODE) ________________________________________________________________________ CID 1033205: Dead default in switch (DEADCODE) /epan/dissectors/packet-epl.c: 786 ( dead_error_condition) 783 } 784 785 /* The rest of the EPL dissector depends on the message type */On this path, the switch value "epl_mtyp" cannot reach the default case.786 switch (epl_mtyp) 787 { 788 case EPL_SOC: 789 offset = dissect_epl_soc(epl_tree, tvb, pinfo, offset); 790 break; /epan/dissectors/packet-epl.c: 721 ( const) 718 col_clear(pinfo->cinfo, COL_INFO); 719 720 /* Choose the right string for "Info" column (message type) */After this line, the value of "epl_mtyp" is equal to 1.721 switch (epl_mtyp) 722 { 723 case EPL_SOC: 724 /* source and destination NodeID are fixed according to the spec */ 725 col_set_str(pinfo->cinfo, COL_INFO, "SoC "); /epan/dissectors/packet-epl.c: 721 ( const) 718 col_clear(pinfo->cinfo, COL_INFO); 719 720 /* Choose the right string for "Info" column (message type) */After this line, the value of "epl_mtyp" is equal to 3.721 switch (epl_mtyp) 722 { 723 case EPL_SOC: 724 /* source and destination NodeID are fixed according to the spec */ 725 col_set_str(pinfo->cinfo, COL_INFO, "SoC "); /epan/dissectors/packet-epl.c: 721 ( const) 718 col_clear(pinfo->cinfo, COL_INFO); 719 720 /* Choose the right string for "Info" column (message type) */After this line, the value of "epl_mtyp" is equal to 4.721 switch (epl_mtyp) 722 { 723 case EPL_SOC: 724 /* source and destination NodeID are fixed according to the spec */ 725 col_set_str(pinfo->cinfo, COL_INFO, "SoC "); /epan/dissectors/packet-epl.c: 721 ( const) 718 col_clear(pinfo->cinfo, COL_INFO); 719 720 /* Choose the right string for "Info" column (message type) */After this line, the value of "epl_mtyp" is equal to 5.721 switch (epl_mtyp) 722 { 723 case EPL_SOC: 724 /* source and destination NodeID are fixed according to the spec */ 725 col_set_str(pinfo->cinfo, COL_INFO, "SoC "); /epan/dissectors/packet-epl.c: 721 ( const) 718 col_clear(pinfo->cinfo, COL_INFO); 719 720 /* Choose the right string for "Info" column (message type) */After this line, the value of "epl_mtyp" is equal to 6.721 switch (epl_mtyp) 722 { 723 case EPL_SOC: 724 /* source and destination NodeID are fixed according to the spec */ 725 col_set_str(pinfo->cinfo, COL_INFO, "SoC "); /epan/dissectors/packet-epl.c: 723 ( equality_cond) 720 /* Choose the right string for "Info" column (message type) */ 721 switch (epl_mtyp) 722 {Jumping to case "1".723 case EPL_SOC: 724 /* source and destination NodeID are fixed according to the spec */ 725 col_set_str(pinfo->cinfo, COL_INFO, "SoC "); 726 break; 727 /epan/dissectors/packet-epl.c: 728 ( equality_cond) 725 col_set_str(pinfo->cinfo, COL_INFO, "SoC "); 726 break; 727Jumping to case "3".728 case EPL_PREQ: 729 /* show only destination NodeID, because source is always 240 (MN) */ 730 col_add_fstr(pinfo->cinfo, COL_INFO, "PReq dst = %3d ", epl_dest); 731 break; 732 /epan/dissectors/packet-epl.c: 733 ( equality_cond) 730 col_add_fstr(pinfo->cinfo, COL_INFO, "PReq dst = %3d ", epl_dest); 731 break; 732Jumping to case "4".733 case EPL_PRES: 734 /* show only source NodeID, because destination is always 255 (broadcast) */ 735 col_add_fstr(pinfo->cinfo, COL_INFO, "PRes src = %3d ", epl_src); 736 break; 737 /epan/dissectors/packet-epl.c: 738 ( equality_cond) 735 col_add_fstr(pinfo->cinfo, COL_INFO, "PRes src = %3d ", epl_src); 736 break; 737Jumping to case "5".738 case EPL_SOA: 739 /* source and destination NodeID are fixed according to the spec */ 740 col_set_str(pinfo->cinfo, COL_INFO, "SoA "); 741 break; 742 /epan/dissectors/packet-epl.c: 743 ( equality_cond) 740 col_set_str(pinfo->cinfo, COL_INFO, "SoA "); 741 break; 742Jumping to case "6".743 case EPL_ASND: 744 if (udpencap) 745 { 746 col_set_str(pinfo->cinfo, COL_INFO, "ASnd "); 747 } /epan/dissectors/packet-epl.c: 808 ( dead_error_begin) 805 offset = dissect_epl_asnd(epl_tree, tvb, pinfo, epl_src, offset); 806 break; 807Execution cannot reach this statement "default:".808 default: /* no valid EPL packet */ 809 return FALSE; 810 } 811 812 return offset; ________________________________________________________________________ To view the defects in Coverity Scan visit, http://scan.coverity.com To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py
--- End Message ---
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- New Defects reported by Coverity Scan for Wireshark (forw) Joerg Mayer (Jun 14)
- Re: New Defects reported by Coverity Scan for Wireshark (forw) Martin Kaiser (Jun 14)
- Re: New Defects reported by Coverity Scan for Wireshark (forw) Joerg Mayer (Jun 18)
- Re: New Defects reported by Coverity Scan for Wireshark (forw) Martin Kaiser (Jun 14)