Wireshark mailing list archives
Re: To display reserved fields or not display reserved fields, that is the question...
From: mmann78 () netscape net
Date: Sun, 8 Dec 2013 11:16:50 -0500 (EST)
The best would be proto_tree_add_item(seg_param_tree, hf_scsi_reserved, tvb, offset, 2, ENC_BIG_ENDIAN) (obviously may need adjusting for your specfic situation) offset += 2 so it's filterable (and users can possibly find situtions where reserved fields aren't 0) Different hf_ filters variables may need to be created if size/bitmasks are different between the reserved fields, but they can all have the same filter name if you want (ie "scsi.reserved"). -----Original Message----- From: Kaul <mykaul () gmail com> To: Developer support list for Wireshark <wireshark-dev () wireshark org> Sent: Sun, Dec 8, 2013 10:55 am Subject: [Wireshark-dev] To display reserved fields or not display reserved fields, that is the question... Should I: proto_tree_add_text(seg_param_tree, tvb, offset, 2, "reserved"); offset += 2; or: offset += 2; /* reserved */ What is better? (Regretully I'm working on SCSI, whose creators LOVED sprinkling reserved bytes everywhere!). Do we have a standard? (perhaps worth having a global param for it?!). Y. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- To display reserved fields or not display reserved fields, that is the question... Kaul (Dec 08)
- Re: To display reserved fields or not display reserved fields, that is the question... mmann78 (Dec 08)
- Re: To display reserved fields or not display reserved fields, that is the question... Edwin Groothuis (Dec 08)