Wireshark mailing list archives
Converting to new proto tree too complex/errorprone
From: Joerg Mayer <jmayer () loplof de>
Date: Sat, 21 Dec 2013 11:27:27 +0100
Hello Jakub, converting a dissector to the new proto tree api is still unnecessarily complex (and I managed to break all buildbots in the course). I've attached a diff between the result of the conversion script output and the currently committed source. Can you please take a look whether at least some of this can be improved (if the script had been in perl I'd probably would have tried to fix some of these things myself). Ciao Jörg -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.
Attachment:
convert-proto-tree-manual.diff
Description:
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Converting to new proto tree too complex/errorprone Joerg Mayer (Dec 21)
- Re: Converting to new proto tree too complex/errorprone Jakub Zawadzki (Dec 21)