Wireshark mailing list archives

mpeg-audio.c warning


From: "Maynard, Chris" <Christopher.Maynard () GTECH COM>
Date: Thu, 12 Dec 2013 16:48:43 -0500

c:\buildbot\wireshark\trunk-vs-eca\vscodeanalysis\build\wsutil\mpeg-audio.c(95) : warning C6385: Invalid data: 
accessing 'mpa_layers', the readable size is '16' bytes, but '4004' bytes might be read: Lines: 95

Maybe someone who understands the intent of this code can provide a fix?  I think the problem is that 
mpa_layers[mpa->layer] could evaluate to -1 if mpa->layer is 0, thereby causing an out-of-bounds access to 
map_padding_data[], but I'm not sure what the correct fix is.  And don't mpa_samples(),  mpa_bitrate() , and  
mpa_frequency()suffer from the same problem?

- Chris
http://news.gmane.org/gmane.network.wireshark.devel
Couldn't contact sea:8010
The web interface is down for maintenance.

--












CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended 
recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, 
distribution or copying of this communication is strictly prohibited. If you have received this communication in error, 
please immediately delete it from your system and notify the sender by replying to this email.  Thank you.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: