Wireshark mailing list archives
Re: tools/make-dissector-reg.py
From: "Gisle Vanem" <gvanem () yahoo no>
Date: Wed, 11 Dec 2013 15:26:12 +0100
"Graham Bloice" <graham.bloice () trihedral com> wrote:
and maybe due to my CMake ineptness it turned out to be one file per line.
How fast will CMake generate such a temp-file? There are approx 1100 packet-*.c files. I figured this macro does it: MACRO(REGISTER_DISSECTOR_FILES _outputfile _registertype ) if(${_registertype} STREQUAL "dissectors" ) set( _makeregistertype "dissectorsinfile" ) set( _ftmp "${CMAKE_CURRENT_BINARY_DIR}/_regc.tmp" ) set( _depends ${ARGN} ) file(REMOVE ${_ftmp}) foreach(f ${_depends}) file(APPEND ${_ftmp} "${f}\n") endforeach()
So, unless you're interested in CMake builds for Visual Studio, you can effectively ignore the changes to make-dissector-reg, but if you feel the need to improve it, then the CMake will have to be fixed at the same time.
Sorry, I don't do CMake. It's a big mystery to me. I seldom get it to work here. But GNU-make rocks even for MSVC projects. --gv ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- tools/make-dissector-reg.py Gisle Vanem (Dec 11)
- Re: tools/make-dissector-reg.py Graham Bloice (Dec 11)
- Re: tools/make-dissector-reg.py Gisle Vanem (Dec 11)
- Re: tools/make-dissector-reg.py Graham Bloice (Dec 11)