Wireshark mailing list archives
dissect_sip_tcp_heur()
From: Martin Kaiser <lists () kaiser cx>
Date: Sat, 10 Aug 2013 15:32:01 +0200
I came across this while browsing through the coverity defects. gboolean first = TRUE; is never changed Does the following change make sense to those who are familiar with SIP? diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c index fa317c8..c04a0c8 100644 --- a/epan/dissectors/packet-sip.c +++ b/epan/dissectors/packet-sip.c @@ -2104,6 +2104,7 @@ dissect_sip_tcp_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void * if (len == -1) break; /* need more data */ offset += len; + first = FALSE; } return TRUE; } ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- dissect_sip_tcp_heur() Martin Kaiser (Aug 10)
- Re: dissect_sip_tcp_heur() Pascal Quantin (Aug 12)
- Re: dissect_sip_tcp_heur() Martin Kaiser (Aug 12)
- Re: dissect_sip_tcp_heur() Hadriel Kaplan (Aug 12)
- Re: dissect_sip_tcp_heur() Martin Kaiser (Aug 12)
- Re: dissect_sip_tcp_heur() Pascal Quantin (Aug 12)