Wireshark mailing list archives
RFC: Any reason not to do this?
From: Martin Mathieson <martin.r.mathieson () googlemail com>
Date: Tue, 23 Apr 2013 16:23:38 -0400
In a profile, I was surprised to see that > 2.5% of time was spent calling dissect_sip_tcp_heur(). There are no SIP PDUs in the log. HTTP was very similar. Does the attached change look reasonable? It does a quick check for the first character being printable before trying to extract the first line and check it for NULL characters. Thanks, Martin
Attachment:
packet-sip.c.diff
Description:
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- RFC: Any reason not to do this? Martin Mathieson (Apr 23)
- Re: RFC: Any reason not to do this? Anders Broman (Apr 23)