Wireshark mailing list archives
Re: [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Sun, 30 Sep 2012 18:32:26 +0200
On Sun, Sep 30, 2012 at 12:01:01PM -0400, Maynard, Chris wrote:
So should r45182 and r45189 be scheduled for backport to fix bug 6208?
I think r45189 is buggy, if wireshark is refiltering, and you get new packets, some packets might have wrong relative timestamps (displayed, captured), and wrong value in cumulative bytes column. I haven't reproduce it, it's just from reading wireshark code. I'm going to fix it, but I want to do it with some code cleanup. If we want to have bug #6208 fixed in 1.x we need to revert r45189 + do: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6208#c9 I'm not sure if I have time for writting such patch, but If anyone write one, I can review. PS: anyway, you need to backport all revisions, reverted one also, cause these reverts were not only reverts, but revert with some code addition :| Regards, Jakub. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c Maynard, Chris (Sep 30)
- Re: [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c Jakub Zawadzki (Sep 30)