Wireshark mailing list archives

r45005: changes in proto_item_append_string()


From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Wed, 19 Sep 2012 14:31:01 +0200

Hi,

I'm looking for r45005 changes and it seems than new proto_item_append_string()
works different than previously.

Old code was changing value of field [both for text and filter],
new version changes only text (so it do the same as proto_item_append_text())

What's the reason of this change? Actually I'm afraid I know.
You want to avoid string formating penatly of proto_item_append_text().

But your changes is breaking current use, like filtering for frame.protocols == "XXXX"

Regards,
 Jakub.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: