Wireshark mailing list archives

Re: [Wireshark-commits] rev 44978: /trunk/epan/ /trunk/epan/: packet.c


From: "Maynard, Chris" <Christopher.Maynard () GTECH COM>
Date: Tue, 18 Sep 2012 15:32:21 -0400

Hmm, isn't this making an assumption about the dissector table?

dissector_add_uint() is used for more than just udp/tcp ports.  Couldn't there be perfectly valid cases of registering 
a value of 0 for other tables besides "udp.port", "tcp.port" and others like those?

- Chris

-----Original Message-----
From: wireshark-commits-bounces () wireshark org [mailto:wireshark-
commits-bounces () wireshark org] On Behalf Of jmayer () wireshark org
Sent: Tuesday, September 18, 2012 3:04 PM
To: wireshark-commits () wireshark org
Subject: [Wireshark-commits] rev 44978: /trunk/epan/ /trunk/epan/:
packet.c

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44978

User: jmayer
Date: 2012/09/18 12:04 PM

Log:
 dissector_add_uint:
    Legalize formerly improper use of the API when calling it with
    pattern value of 0

Directory: /trunk/epan/
  Changes    Path          Action
  +46 -39    packet.c      Modified

_______________________________________________________________________
____
Sent via:    Wireshark-commits mailing list <wireshark-
commits () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-
request () wireshark org?subject=unsubscribe
CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended 
recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, 
distribution or copying of this communication is strictly prohibited. If you have received this communication in error, 
please immediately delete it from your system and notify the sender by replying to this email.  Thank you.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: