Wireshark mailing list archives
Re: RFD: Limiting scope of ep_ memory
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Mon, 22 Oct 2012 19:45:14 +0200
On Mon, Oct 22, 2012 at 12:43:49PM -0400, Evan Huus wrote:
On Mon, Oct 22, 2012 at 12:21 PM, Anders Broman- My feeling is that mixing ep and g_malloced memory in pinfo is a bad idea.Yes. Perhaps pinfo should have its own scope that is between ep and se? This would be much easier given the changes suggested in [1].
Looking at packet_info structure only sccp_info[1] is ep allocated, but it's safe, cause only used when dissecting packet. ... and sometimes address->data is pointed to ep_ pool. Generally it's simillar case like with col_set_str(ep_memory_pool). This one is checked with ep_verify_pointer. So before ep_free_all(): DISSECTOR_ASSERT(!ep_verify_pointer(edt->pi.src.data)); DISSECTOR_ASSERT(!ep_verify_pointer(edt->pi.dst.data)); DISSECTOR_ASSERT(!ep_verify_pointer(edt->pi.net_src.data)); DISSECTOR_ASSERT(!ep_verify_pointer(edt->pi.net_dst.data)); /* ... */ ? ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- RFD: Limiting scope of ep_ memory Jakub Zawadzki (Oct 11)
- Re: RFD: Limiting scope of ep_ memory Evan Huus (Oct 11)
- Re: RFD: Limiting scope of ep_ memory Anders Broman (Oct 12)
- Re: RFD: Limiting scope of ep_ memory Jakub Zawadzki (Oct 14)
- Re: RFD: Limiting scope of ep_ memory Martin Mathieson (Oct 14)
- Re: RFD: Limiting scope of ep_ memory Anders Broman (Oct 16)
- Re: RFD: Limiting scope of ep_ memory Jakub Zawadzki (Oct 22)
- Re: RFD: Limiting scope of ep_ memory Jakub Zawadzki (Oct 22)
- Re: RFD: Limiting scope of ep_ memory Anders Broman (Oct 22)
- Re: RFD: Limiting scope of ep_ memory Evan Huus (Oct 22)
- Re: RFD: Limiting scope of ep_ memory Jakub Zawadzki (Oct 22)
- Re: RFD: Limiting scope of ep_ memory Jakub Zawadzki (Oct 22)
- Re: RFD: Limiting scope of ep_ memory Evan Huus (Oct 22)
- Re: RFD: Limiting scope of ep_ memory Evan Huus (Oct 23)
- Re: RFD: Limiting scope of ep_ memory Anders Broman (Oct 12)
- Re: RFD: Limiting scope of ep_ memory Jeff Morriss (Oct 25)
- Re: RFD: Limiting scope of ep_ memory Evan Huus (Oct 11)
- Re: RFD: Limiting scope of ep_ memory Evan Huus (Oct 22)
- Re: RFD: Limiting scope of ep_ memory Jakub Zawadzki (Oct 22)