Re: [Wireshark-commits] rev 43695: /trunk/epan/ /trunk/epan/: addr_resolv.c

[Jeff Morriss <jeff.morriss.ws () gmail com>]

cmaynard () wireshark org wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43695
>
> User: cmaynard
> Date: 2012/07/13 01:09 PM
>
> Log:
>  tp->name can't be NULL, but perhaps tp can be?
>  Fixes Coverity CID 709597: Array compared against 0.

Old code:

> 3024    tp = host_lookup(ip, &found);
> 3025    if (tp->name == NULL)
> 3026    return;


Actually I suppose what was meant is more about whether tp->name[0] is 
the NULL character (that is, that the name is empty).

But since the result of the lookup is already there in 'found' the whole 
condition can probably be taken out.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe