Wireshark mailing list archives
Re: RFD: Creating subdirectories in epan/dissectors/
From: David Aggeler <david_aggeler () hispeed ch>
Date: Thu, 30 Aug 2012 22:32:16 +0200
Well I used to work on packet-dcm for a while, and considering myself a novice, it was painful to find 'my' files after all the packet-dcep.... Try to type the filename in the directory. If you don't get all 10 character right, you're off. So for me it would have been a benefit to take the big ones out to allow typing in the file explorer.[Graham Bloice said] Some folks have articulated the drawbacks (to them) of making these changes but I haven't seen any actual advantages listed. Can anyone list them as they see it?
>> fold into one large fileI really hate the 3100 lines of protocol definitions in packet-dcm.c , but since i didn't consider the protocol that important, I never dared to ask for a 2nd .c file. And comments were not that friendly, when I had it in the include file.
In addition, I also don't see the benefit in the 'packet-' prefix.And since we are at it, the 'epan' directory for sure makes sense to all those working on the framework, but for me as a dissector contributor, it's just a deeper hierarchy.
David ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: RFD: Creating subdirectories in epan/dissectors/, (continued)
- Re: RFD: Creating subdirectories in epan/dissectors/ Evan Huus (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Anders Broman (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Mike Morrin (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Jakub Zawadzki (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Jeff Morriss (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Evan Huus (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Ed Beroset (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Evan Huus (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Evan Huus (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Graham Bloice (Aug 31)
- Re: RFD: Creating subdirectories in epan/dissectors/ David Aggeler (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Jaap Keuter (Aug 30)
- Re: RFD: Creating subdirectories in epan/dissectors/ Evan Huus (Aug 30)