Wireshark mailing list archives

Re: WinPcap_4_1_2.exe in 1.8.0rc1


From: Jaap Keuter <jaap.keuter () xs4all nl>
Date: Wed, 29 Aug 2012 23:51:47 +0200

On 06/12/2012 01:52 PM, Balint Reczey wrote:
Hi,

I have just noticed that we ship an .exe file in the source tarball.
I think it would be nicer to get this installer downloaded during the Windows
development environment setup like we do with many other libraries.
We also have his installer committed to SVN (Git) as part of the source which
may not be the best practice.

Cheers,
Balint

Looking at it I'd say: +1

Move it to Wireshark-win32/64-libs and wget it from there, since it's only needed for the Windows build of the installers. You can get it through the use of $(WIRESHARK_LIB_DIR).

Just my E0.02
Jaap


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: