Wireshark mailing list archives
Re: [Wireshark-commits] rev 44559: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sctp.c
From: mmann78 () netscape net
Date: Tue, 21 Aug 2012 14:47:53 -0400 (EDT)
SCTP isn't the only dissector doing it's own reassembly (at least from what I can see grepping g_ allocation calls), but I agree having it use the reassembly API (if possible) would be preferred over reverting my se_ alloc changes. Unfortunately, sometimes ignorance is the reason a provided API isn't used, and for something like reassembly, not something someone unfamiliar with the protocol is likely to try to correct. Experience is always the best teacher and since I haven't tried the reassembly API, maybe I'll take a shot at the SCTP dissector. If it drops in simply and cleanly, I'll commit something. If not, I'll probably revert my se_ alloc changes and submit an enhancement request for someone willing to take on the task. -----Original Message----- From: Jeff Morriss <jeff.morriss.ws () gmail com> To: Developer support list for Wireshark <wireshark-dev () wireshark org> Sent: Tue, Aug 21, 2012 2:29 pm Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 44559: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sctp.c I don't remember why SCTP's reassembly was done without reassemble.c; assuming that the existing APIs didn't quite work for some reason, maybe SCTP's routines could be generalized and added to reassemble.c in order to push the g_malloc()'s out of the dissector. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 44559: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sctp.c Jeff Morriss (Aug 20)
- <Possible follow-ups>
- Re: [Wireshark-commits] rev 44559: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sctp.c mmann78 (Aug 20)
- Re: [Wireshark-commits] rev 44559: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sctp.c mmann78 (Aug 21)