Wireshark mailing list archives
Re: [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c
From: Michael Tüxen <Michael.Tuexen () lurchi franken de>
Date: Wed, 9 Nov 2011 22:29:10 +0100
On Nov 9, 2011, at 10:09 PM, Bill Meier wrote:
On 11/9/2011 3:45 PM, stig () wireshark org wrote:http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39775 User: stig Date: 2011/11/09 12:45 PM Log: As reported by Michael Speck: Removed last occurrences of USE_THREADS. Directory: /trunk/ Changes Path Action +0 -4 CMakeLists.txt Modified +1 -6 dumpcap.c ModifiedStig: Any reason not to remove all the 'if (use_threads)' tests (just leaving the threads branches of the code) ??
dumpcap behaves differently if you capture from a single interface. Without the -t flag, the program uses a single thread only. Using -t, you have one reader thread for the interface and one thread writing the stuff to disk. So I think it makes sense to leave the ifs in the dumpcap.c code. Best regards Michael
Bill ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c Bill Meier (Nov 09)
- Re: [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c Michael Tüxen (Nov 09)
- Re: [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c Guy Harris (Nov 09)
- Re: [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c Michael Tüxen (Nov 09)
- Re: [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c Jaap Keuter (Nov 09)
- Re: [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c Michael Tüxen (Nov 10)
- Re: [Wireshark-commits] rev 39775: /trunk/ /trunk/: CMakeLists.txt dumpcap.c Michael Tüxen (Nov 09)