Wireshark mailing list archives

Re: [Wireshark-commits] rev 37417: /trunk/ /trunk/: dumpcap.c


From: Gerald Combs <gerald () wireshark org>
Date: Thu, 26 May 2011 16:34:58 -0700

I backed out the g_log lines. Thanks for catching that.

On 5/26/11 4:13 PM, Maynard, Chris wrote:
Is the debugging output OK to be added?  The note just above seems to indicate that it's not OK to call g_log().
- Chris
________________________________________
From: wireshark-commits-bounces () wireshark org [wireshark-commits-bounces () wireshark org] On Behalf Of gerald () 
wireshark org [gerald () wireshark org]
Sent: Thursday, May 26, 2011 6:12 PM
To: wireshark-commits () wireshark org
Subject: [Wireshark-commits] rev 37417: /trunk/ /trunk/: dumpcap.c

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37417

User: gerald
Date: 2011/05/26 03:12 PM

Log:
 Don't call pcap_breakloop() if we're not capturing anything. Fixes a
 crash found by Stig.

 Add debugging output to capture_cleanup_handler() on non-Windows
 systems.

Directory: /trunk/
  Changes    Path          Action
  +12 -5     dumpcap.c     Modified
CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and 
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


-- 
Join us for Sharkfest ’11! · Wireshark® Developer and User Conference
Stanford University, June 13-16 · http://sharkfest.wireshark.org
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: