Wireshark mailing list archives
Re: [Wireshark-commits] rev 37282: /trunk/gtk/ /trunk/gtk/: tcp_graph.c
From: Anders Broman <anders.broman () ericsson com>
Date: Thu, 19 May 2011 09:58:28 +0200
Hi,
Is the second part of the patch (added inside the else clause) correct?
Looks ok, perhap an assert or g_warning as it shouldn't happen? Thanks for cleaning things up. Best regards Anders -----Original Message----- From: wireshark-commits-bounces () wireshark org [mailto:wireshark-commits-bounces () wireshark org] On Behalf Of jmayer () wireshark org Sent: den 19 maj 2011 07:45 To: wireshark-commits () wireshark org Subject: [Wireshark-commits] rev 37282: /trunk/gtk/ /trunk/gtk/: tcp_graph.c http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37282 User: jmayer Date: 2011/05/18 10:44 PM Log: Fix two warning in case of UIMANAGER: - Unused variable - 'graph_type' may be used uninitialized Is the second part of the patch (added inside the else clause) correct? Directory: /trunk/gtk/ Changes Path Action +3 -1 tcp_graph.c Modified ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-request () wireshark org?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 37282: /trunk/gtk/ /trunk/gtk/: tcp_graph.c Anders Broman (May 19)