Re: [Wireshark-commits] rev 37833: /trunk/ /trunk/docbook/: release-notes.xml /trunk/gtk/: capture_file_dlg.c /trunk/: packet-range.c /trunk/win32/: file_dlg_win32.c

["Maynard, Chris" <Christopher.Maynard () GTECH COM>]

Yes, I reverted it in r37839: 
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37839

Sake had a better patch that he was working on and posted on -core as save-as.diff.  My understanding is that the patch 
would only work for non-Windows platforms though, so I think all we need now is for someone with more GTK+Windows 
knowledge than I to take Sake's solution and extend it to Windows. 

Re-attaching Sake's comments and patch for convenience:

=====[BEGIN QUOTE]=====
I would vote against defaulting to saving only displayed frames when "File -> Save" is used. My reasoning... (from 
practical use of wireshark)... I captured packets, started to do some analysis involving filtering, then when I find 
the file interesting indeed, I would want to save the whole file.

I don't want to be unpleasantly surprised by not having all packets in my capture file. "File -> Save" is only active 
on non-saved files, so it would make sense to always save every packet as it has not been saved before. For "File -> 
Save As" I do agree that it would be logical to save only the displayed frames, as you expect to save the transformed 
file (it is no use saving the file in the same form again).

That is how I interpreted the request at Sharkfest :-)

I attached the change I have in mind for non-windows systems, so you see what I plan to implement...

Cheers,


Sake
=====[END QUOTE]=====

- Chris

> -----Original Message-----
> From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-
> bounces () wireshark org] On Behalf Of Stephen Fisher
> Sent: Friday, July 15, 2011 11:31 AM
> To: wireshark-dev () wireshark org
> Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37833: /trunk/
> /trunk/docbook/: release-notes.xml /trunk/gtk/: capture_file_dlg.c
> /trunk/: packet-range.c /trunk/win32/: file_dlg_win32.c
>
> This doesn't seem to be working - did it get reverted?
>
> On Wed, Jun 29, 2011 at 04:31:50PM +0000, cmaynard () wireshark org wrote:
> >
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37833
> > User: cmaynard
> > Date: 2011/06/29 09:31 AM
> >
> > Log:
> >  Based on user feedback from Sharkfest '11, make the default choice
> when saving or printing packets apply to only displayed packets and not
> all packets.












CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and 
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.

Attachment: save-as.diff
Description: save-as.diff

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe