Re: [Wireshark-commits] rev 38028: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-icmp.c

[Sake Blok <sake () euronet nl>]

On 15 jul 2011, at 02:34, Maynard, Chris wrote:

> > Log:
> > If the first 8 bytes of the icmp echo/echo-reply data look like a
> > timestamp, dissect it as a timestmap and calculate the time since the icmp
> > packet was created.
>
> Sake, now that you've dug into timestamps for ICMP echo/echo-reply data, maybe you might have some thoughts about how 
> to improve the last patch I submitted to bug 5770 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5770)?  I'm 
> sure the patch will no longer apply cleanly now, but hopefully you can get a feel for what I was trying to do.  If 
> you really want, I can resubmit a patch that will apply cleanly to the trunk.

Nice idea, but that won't really work well, see my response in the bug-report...

Cheers,
Sake
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe