Wireshark mailing list archives

Re: [Wireshark-commits] rev 38772: /trunk/gtk/ /trunk/gtk/: main_menubar.c


From: Anders Broman <anders.broman () ericsson com>
Date: Mon, 29 Aug 2011 15:44:44 +0200

 

-----Original Message-----
From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Joerg Mayer
Sent: den 29 augusti 2011 15:41
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 38772: /trunk/gtk/ /trunk/gtk/: main_menubar.c

On Mon, Aug 29, 2011 at 02:59:58PM +0200, Anders Broman wrote:
Un comment:
3215 /*char *gui_desc_file_name;*/
: 
3387
             /*gui_desc_file_name = g_strdup_printf("%s" G_DIR_SEPARATOR_S "ui" G_DIR_SEPARATOR_S 
"main-menubar-ui.xml", get_datafile_dir());
             gtk_ui_manager_add_ui_from_file ( ui_manager_main_menubar, 
gui_desc_file_name, &error);*/
:
3395
/*g_free (gui_desc_file_name);*/

Thanks, turned that into a conditional compile. Then I modified get_datafile_dir to take a fallback path as an 
argument.
For this to work, I ran wireshark like this:

WIRESHARK_RUN_FROM_BUILD_DIRECTORY=1 WIRESHARK_SRC_DIR=../trunk ./wireshark

Does passing a fallback path into get_datafile_dir make sense for more cases? Right now I only provided the ui case 
with a fallback but diameter, radius and python come to my mind as well.

Plugins ?


-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft 
instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: