Re: localtime_r() in gtk/timeshift_dlg.c

[Gisle Vanem <gvanem () broadpark no>]

"Stig Bjørlykke" <stig () bjorlykke org> wrote:

> On Tue, Aug 16, 2011 at 12:17 AM, Gisle Vanem <gisle.vanem () gmail com> wrote:
> > This:
> > #ifdef _MSC_VER
> > #define localtime_r(a, b) memcpy((b), localtime((a)), sizeof(struct tm));
> > #endif
> >
> > doesn't look so safe. We should maybe use the localtime_r() in
> > wsutil/strptime.c?
>
> Or simply just use localtime, check the return value and then copy the values.
> Like in revision 38569.

Agreed, that's better.

PS. Notice that my 1st email came from <gisle.vanem () gmail com> and took
approx. 6 hours to get on this list. Waiting for what? My normal address (the one
I subscribed from and the one I reply from now) is <gvanem () broadpark no>.
So it seems Mailman doesn't care so much about the address, but rather my name.
Anyone can subscribe and claim to be me. Doesn't sound correct.

--gv

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe