Re: Unusual test in capture_dlg.c

[Michael Tuexen <Michael.Tuexen () lurchi franken de>]

On Aug 6, 2011, at 12:13 PM, Joerg Mayer wrote:

> Hello,
>
> I have some questions regarding the following code inside the function
> select_if_type_cb:
>
> #if GTK_CHECK_VERSION(2,6,0)
>      if (new_iftype == num_remote + 4)
> #else
>      if (new_iftype == num_remote + 2)
> #endif
>
> What's the idea behind it? Is the version of 2.6.0 correct? If so, this
> check can be removed as we require at least version 2.12 to build at all.
I have no idea, but the code is already in trunk-1.6, so it is old.
I would vote for removing the check...

Best regards
Michael
> Thanks
>    Joerg
>
> -- 
> Joerg Mayer                                           <jmayer () loplof de>
> We are stuck with technology when what we really want is just stuff that
> works. Some say that should read Microsoft instead of technology.
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe