Wireshark mailing list archives
Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c
From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Fri, 22 Apr 2011 11:18:22 -0400
Stephen Fisher wrote:
On Fri, Apr 22, 2011 at 03:09:01PM +0200, Alexis La Goutte wrote:Why not add a check (in checkAPIs.pl) if proto_item_add_subtree always return a value ?Good idea. Another way to do it is a gcc attribute called warn_unused_result:http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html
That was my thought this morning as well; I added that check (after fixing all the resulting warnings) in rev 36812.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Stig Bjørlykke (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Alexis La Goutte (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Stig Bjørlykke (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Jeff Morriss (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Alexis La Goutte (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Stephen Fisher (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Jeff Morriss (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Alexis La Goutte (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Jakub Zawadzki (Apr 22)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Stig Bjørlykke (Apr 21)
- Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c Alexis La Goutte (Apr 21)