Re: [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-l2tp.c

[Stig Bjørlykke <stig () bjorlykke org>]

On Thu, Apr 21, 2011 at 3:32 PM,  <alagoutte () wireshark org> wrote:
>  Fix Dead Store (Dead nested assignment) Warning found by Clang

-                                       msg_type = tvb_get_ntohs(tvb, (tmp_idx+=2));
+                                       msg_type = tvb_get_ntohs(tvb, tmp_idx);

Are you sure this is correct?  What about "tmp_idx+2"?


-- 
Stig Bjørlykke
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe