Wireshark mailing list archives

Re: Compilation errors


From: Stig Bjørlykke <stig () bjorlykke org>
Date: Thu, 21 Apr 2011 13:52:21 +0200

On Thu, Apr 21, 2011 at 1:30 PM, Anders Broman
<anders.broman () ericsson com> wrote:
Ok, but both case 1 and the default branch (with GEOIP) ends in g_assert unless I'm misstaken and that's hardly the 
intention is it?

case 1 has a CMP_INT which does return.  The default branch is only
used for GEOIP because we only use hostlist_sort_column with values 0
and 1 without GEOIP.  But I'm not sure if we will get a warning about
unused code if we always return before g_assert, and g_assert is
intended here, so maybe the "return 0" will be wrong.


-- 
Stig Bjørlykke
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: