Re: [Wireshark-commits] rev 36614: /trunk/ /trunk/epan/dissectors/: packet-snmp.c /trunk/asn1/snmp/: packet-snmp-template.c

[Stephen Fisher <steve () stephen-fisher com>]

On Wed, Apr 13, 2011 at 07:57:35AM +0200, Stig Bjørlykke wrote:
> On Wed, Apr 13, 2011 at 12:12 AM,  <sfisher () wireshark org> wrote:
> > Log:
> >  Fix Coverity 1047: UNUSED_VALUE in dissect_smux
>
> I don't think this is the correct fix, because now the 
> proto_item_add_subtree() has no function. I think maybe smux_tree 
> should be used in dissect_SMUX_PDUs_PDU().

Thanks for pointing that out.  I've reversed my commit and changed the 
dissect_SMUX_PDUs_PDU() call to use smux_tree instead in r36624.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe