Patch for empty SSH env variables

[Charles Rumford <charlesr () cs drexel edu>]

hello all -

Recently, I started using ssh-agent. When I started using this, Wireshark
started to seg fault on me every time I ran it. Not realizing that it was the
ssh-agent, I just assumed that my computer sucked, and that I would never be
able to run Wireshark on my computer.

A friend of mine had been having the same issue, and we decided to dive into
the code and figure out what was going one. It turns out that ssh-agent set
the SSH_CONNECTION and SSH_CLIENT environment variables to the empty string
when on the local machine.  Because of this in util.c, in *get_conn_cfilter(),
tokens[0] is null and there is no check to get around this.

I have attached patch to fix this problem. Does this seem like a reasonable
fix for this problem?

-- 
Charles Rumford
Quick meaningless comic non sequitur.

Attachment: wireshark-check-for-null-ssh-env-var.patch
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe