Wireshark mailing list archives
Re: Submitted patch to packet-netflow.c
From: Kirby Files <ksfiles () gmail com>
Date: Tue, 22 Dec 2009 16:53:39 -0500
Stephen Fisher wrote on 12/22/2009 02:58 PM:
On Dec 22, 2009, at 12:40 PM, Kirby Files wrote:I've created a patch to add these fields to packet-netflow.c, and submitted it as bug #4345: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4345 I'd love it if someone could review the patch, as I haven't done much hacking on wireshark, and am not familiar with all general coding style preferences, nor dissector best practices.Thanks for your contribution! Someone will get to it when they get a chance. Could you attach to the bug a sample capture file that contains packets with the information the patch covers? I'll put this note in the bug too.
I tried, but as I emailed to wireshark-users: Kirby Files wrote on 12/22/2009 02:33 PM:
I recently opened bug 4345 to submit a patch to packet-netflow.c: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4345 Following the developer guidelines, I also attempted to submit a .pcap demonstrating the new Netflow fields I was adding. However, each time I attempt to do so, I get an error: "You already used the form to file attachment 4082." Perhaps bugzilla is being a little overzealous in de-duping? I cannot find anyway around this error. In any case, I've attached the sample .pcap to this message in case someone receiving it can add it to the above bug.
I'll attach the same pcap to this msg too, in case it can get through and be added by someone else to the bug.
Thanks, --- Kirby Files ksfiles () gmail com
Attachment:
netflow-nbar.pcap
Description:
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Submitted patch to packet-netflow.c Kirby Files (Dec 22)
- Re: Submitted patch to packet-netflow.c Stephen Fisher (Dec 22)
- Re: Submitted patch to packet-netflow.c Kirby Files (Dec 22)
- Re: Submitted patch to packet-netflow.c Stephen Fisher (Dec 22)
- Re: Submitted patch to packet-netflow.c Kirby Files (Dec 22)
- Re: Submitted patch to packet-netflow.c Stephen Fisher (Dec 22)