Re: [tcpdump] After setjmp/longjmp update

[Francois-Xavier Le Bail via tcpdump-workers <tcpdump-workers () lists tcpdump org>]

> --- Begin Message ---
>
>
> From: Francois-Xavier Le Bail <devel.fx.lebail () orange fr>
>
> Date: Wed, 23 Sep 2020 13:29:14 +0200
>
> On 20/09/2020 18:28, Michael Richardson wrote:
> > Given:
> >
> >       case CTRL_BA:
> > (*)           ND_TCHECK_LEN(p, CTRL_BA_HDRLEN);
> >               if (!ndo->ndo_eflag)
> >                       ND_PRINT(" RA:%s ",
> >                           GET_ETHERADDR_STRING(((const struct ctrl_ba_hdr_t *)p)->ra));
> >               break;
> >
> > If we remove (*), if the eflag is not set, then the GET_ETHERADDR_STRING()
> > won't be called, and there will be no truncated warning at this point.
> > Is that the right thing?
>
> Answer here:
> https://github.com/the-tcpdump-group/tcpdump/pull/875#pullrequestreview-493054552
> (point 3)
>
> --- End Message ---
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers