tcpdump mailing list archives

Re: RCS/CVS keywords ($Id$, $Header$, $OpenBSD$ etc)


From: Guy Harris <guy () alum mit edu>
Date: Wed, 1 Jan 2014 11:34:27 -0800


On Jan 1, 2014, at 4:35 AM, Denis Ovsienko <infrastation () yandex ru> wrote:

there are lines in the tcpdump source code that served a purpose with CVS and its keywords expansion feature but 
don't do any more with git. It is around 4 years since the CVS/git migration and perhaps it is the time to remove 
most of the markers.

It seems to be OK to just remove the lines that essentially state "this file is a part of the tcpdump source tree and 
is original to it", for example:

#ifndef lint
static const char rcsid[] _U_ =
   "@(#) $Header: /tcpdump/master/tcpdump/print-ospf.c,v 1.66 2007-10-08 07:53:21 hannes Exp $ (LBL)";
#endif

Please note that no such ID dates any later than end of 2008.

The tcpdump/libpcap RCS/CVS IDs serve no purpose now that libpcap and tcpdump are kept in Git, as far as I can see.

That said, I see sense in preserving/converting the IDs that indicate the origin/relation of the source code, for 
example:

/*   $NetBSD: print-ah.c,v 1.4 1996/05/20 00:41:16 fvdl Exp $        */

Yes, those might be worth preserving.

_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers


Current thread: