tcpdump mailing list archives

Re: 'private' in pcap-int.h


From: Guy Harris <guy () alum mit edu>
Date: Wed, 7 Aug 2013 10:29:46 -0700


On Aug 7, 2013, at 6:42 AM, Gisle Vanem <gvanem () broadpark no> wrote:

'struct pcap' has a member:

void *private;  /* private data for methods */

Which doesn't work so well when including pcap-int.h
from a C++ program. The file looks to be meant for C++
because of:

#ifdef __cplusplus
extern "C" {
#endif

Can this be renamed to 'priv'

Yes.  I've checked in a change to do that.

However, note that pcap-int.h should only be included by pcap modules; if there's something in there that applications 
or other libraries are using, they should either stop using it, or it should be provided by the libpcap API (in a form 
that doesn't expose the internal details of particular pcap modules' private data - the whole point of the change is to 
allow modules to have whatever they need as private data without having to change anything in libpcap or in code using 
libpcap).
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers


Current thread: