tcpdump mailing list archives
Re: [Patch] print-dhcp6.c
From: Guy Harris <guy () alum mit edu>
Date: Tue, 26 Mar 2013 10:38:51 -0700
On Mar 26, 2013, at 6:08 AM, Gisle Vanem <gvanem () broadpark no> wrote:
This file doesn't compile using MSVC v16 (from VC-Express 2010) because it has variable definitions after statements ('<< problem X' below). tcpdump should be in pure C, not C++ or gcc features. Right?
Right. (GCC features are OK if 1) they're protected with an #ifdef/#if and 2) if the #ifdef/#if test fails, the resulting code works the same as if it succeeds. See, for example, extract.h, which uses __attribute__() if the compiler supports it, but still works if the compiler doesn't support it.) I've checked your fix into the trunk and the 4.4 branch. _______________________________________________ tcpdump-workers mailing list tcpdump-workers () lists tcpdump org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Current thread:
- [Patch] print-dhcp6.c Gisle Vanem (Mar 26)
- Re: [Patch] print-dhcp6.c Guy Harris (Mar 26)