tcpdump mailing list archives

Re: [PATCH] ifSpeed in sFlow is 64 bits not 32


From: Rick Jones <rick.jones2 () hp com>
Date: Thu, 02 Jun 2011 11:10:54 -0700

On Thu, 2011-06-02 at 10:57 -0700, Guy Harris wrote:
On May 27, 2011, at 5:59 PM, Rick Jones wrote:

The ifSpeed field of a generic interface counter in sFlow is 64 bits.
The "overlay" definition in print-sflow.c is correct, but the actual
extract for printing is using EXTRACT_32BITS rather than EXTRACT_64BITS,
which leads to an incorrect report for speed.

Checked into the trunk and 4.2 branches 

Excellent.

(with a fix to the format string to use PRIu64).

Oops - I keep forgetting that all my compiles are 64 bit and so don't
remember to check for such things.

rick

-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Current thread: